Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/simple publishing #1015

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Feature/simple publishing #1015

merged 3 commits into from
Nov 27, 2023

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 23, 2023

Implement the simple version of publishing.
This publishes all available variants, no publish dialog, also no unpublish button, as we are still missing the button drop-up UI.
Also, notice publish API does not support segments, and I think this needs to be changed to a different model like:

{
    variants: [
        {
            culture: string | null
            segment: string | null
        }
    ]
}

This would be futureproof, and allow for even more props pr. variant and as well using null for invariant or not-segmented seems more correct to me.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe marked this pull request as draft November 23, 2023 08:15
@nielslyngsoe nielslyngsoe marked this pull request as ready for review November 23, 2023 08:25
@nielslyngsoe nielslyngsoe requested review from iOvergaard and removed request for madsrasmussen November 23, 2023 12:18
@nielslyngsoe nielslyngsoe merged commit 7cee07d into main Nov 27, 2023
6 checks passed
@nielslyngsoe nielslyngsoe deleted the feature/simple-publishing branch November 27, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants